From 4440298327cc552702c518e6f2bae504b77e315f Mon Sep 17 00:00:00 2001 From: Marius Stanciu Date: Wed, 11 Sep 2019 07:06:32 +0300 Subject: [PATCH] - fixed the TclCommand MillHoles --- FlatCAMObj.py | 6 ++++-- README.md | 1 + tclCommands/TclCommandMillHoles.py | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/FlatCAMObj.py b/FlatCAMObj.py index b510d1e8..3ca14187 100644 --- a/FlatCAMObj.py +++ b/FlatCAMObj.py @@ -2633,8 +2633,10 @@ class FlatCAMExcellon(FlatCAMObj, Excellon): for tool in tools: if tooldia > self.tools[tool]["C"]: - self.app.inform.emit('[ERROR_NOTCL] %s' % - _("Milling tool for DRILLS is larger than hole size. Cancelled.")) + self.app.inform.emit('[ERROR_NOTCL] %s %s: %s' % ( + _("Milling tool for DRILLS is larger than hole size. Cancelled.", + str(tool)) + )) return False, "Error: Milling tool is larger than hole." def geo_init(geo_obj, app_obj): diff --git a/README.md b/README.md index 1b857cd3..c0d24652 100644 --- a/README.md +++ b/README.md @@ -15,6 +15,7 @@ CAD program, and create G-Code for Isolation routing. - whenever a Gerber file is deleted, the mark_shapes objects are deleted also - made faster the Gerber parser for the case of having a not valid geometry when loading a Gerber file without buffering - updated code in self.on_view_source() to make it more responsive +- fixed the TclCommand MillHoles 10.09.2019 diff --git a/tclCommands/TclCommandMillHoles.py b/tclCommands/TclCommandMillHoles.py index 38fc222b..8826f856 100644 --- a/tclCommands/TclCommandMillHoles.py +++ b/tclCommands/TclCommandMillHoles.py @@ -82,7 +82,7 @@ class TclCommandMillHoles(TclCommandSignaled): del args['name'] # This runs in the background... Is blocking handled? - success, msg = obj.generate_milling(**args) + success, msg = obj.generate_milling_drills(**args) except Exception as e: self.raise_tcl_error("Operation failed: %s" % str(e))