Jakub Jelen
62403eec34
tcos: Use memset instead of for cycle
2020-06-09 13:02:27 +02:00
Jakub Jelen
9dd3370673
oberthur: Fix operator precedence
...
Thanks oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22665
2020-06-09 13:02:27 +02:00
Jakub Jelen
a5f04188bc
pteid: Do not overwrite already set information in tokeninfo
...
Thanks oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22578
2020-06-09 13:02:27 +02:00
Jakub Jelen
f49162af04
Avoid memory leaks when initializing tokeninfo in various drivers
...
Thanks oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22578
2020-06-09 13:02:27 +02:00
Jakub Jelen
71d1f69a3a
Reformat tcos_compute_signature() for better readability
2020-06-09 13:02:27 +02:00
Jakub Jelen
e6848b6d88
tcos: Yet anoter buffer underflow as previous
2020-06-09 13:02:27 +02:00
Jakub Jelen
fa719b301f
tcos: Prevent buffer underflow
...
Thanks oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22995
2020-06-09 13:02:27 +02:00
Jakub Jelen
d141b35596
tcos: Rewrite assert to explicit check
2020-06-09 13:02:27 +02:00
Jakub Jelen
1819ca33d6
tcos_decipher: Reformat to improve readability
2020-06-09 13:02:27 +02:00
Jakub Jelen
53395f4075
tcos: Replace assert with explicit check
...
Thanks oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22999
2020-06-09 13:02:27 +02:00
Jakub Jelen
8940ed5d85
tcos: Avoid memory leak on invalid inputs
...
(make sure the pointer is initialized)
Thanks oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22765#c2
2020-06-09 13:02:27 +02:00
Jakub Jelen
b418601942
pkcs11-spy: Dump slot id for C_WaitForSlotEvent
2020-06-09 13:02:27 +02:00
Frank Morgner
36247d85b0
pkcs11: fixed notifying twice in case of an attached reader
...
before 14e396273
sc_wait_for_event() only notified in case of a new
reader, but didn't add it to the internal list of readers. That's why
PKCS#11 needed to bail out early in this case (and the application had
to call C_WaitForSlotEvent a second time to actually get the related
slot). Since sc_wait_for_event() can now handle insertion correctly, we
can now immediately check (and reset) the events on the slots.
2020-06-09 12:07:04 +02:00
Frank Morgner
1c7b311289
pcsc: immediately exit on hotplug events
...
fixes delayed notification for removed readers
closes https://github.com/OpenSC/OpenSC/issues/2021
2020-06-09 12:07:04 +02:00
Frank Morgner
8f6e5dc2b0
Unbreak wait for events
...
By Jabuk Jelen
Fixes https://github.com/OpenSC/OpenSC/issues/2021
2020-06-09 12:07:04 +02:00
Frank Morgner
1bb2547abc
respect PKCS#11 allowed return values
2020-06-08 14:18:23 +02:00
Frank Morgner
6a6b3e4b62
prevent memory leak
2020-06-08 14:18:23 +02:00
Frank Morgner
58b03b68dd
check for unbound cards
...
closes https://github.com/OpenSC/OpenSC/pull/2045
2020-06-08 14:18:23 +02:00
Luka Logar
a10b661f99
IsoApplet: Fix uninitialized public key oid during key generation
2020-06-05 14:48:50 +02:00
Peter Marschall
ca5f5c8844
explorer: set stdout to O_BINARY in Windows where needed
2020-06-05 14:48:08 +02:00
Peter Marschall
5714dbfa08
opensc-explorer: add function 'get_record'
2020-06-05 14:48:08 +02:00
Peter Marschall
f55c4e5c93
opensc-explorer: extend path_to_filename()
...
Expect a record number as 3rd parameter:
if this record number is greater than 0, indicating a single record,
then append the record number to the file name being constructed.
2020-06-05 14:48:08 +02:00
Frank Morgner
180c57fd15
fixed compiler warning
2020-06-05 09:43:38 +02:00
Frank Morgner
0f0e0b2e30
prevent out of bounds read
...
fixes https://oss-fuzz.com/testcase-detail/5769298181357568
2020-06-05 08:31:19 +02:00
Frank Morgner
9d294de90d
prevent out of bounds write
...
fixes https://oss-fuzz.com/testcase-detail/5226571123392512
2020-06-04 10:04:10 +02:00
Frank Morgner
55fd3db2b5
prevent integer underflow and subsequent heap overflow
...
fixes https://oss-fuzz.com/testcase-detail/5666689944649728
2020-06-04 09:47:22 +02:00
Frank Morgner
4bc03cb55d
fixed memory leak
...
fixes https://oss-fuzz.com/testcase-detail/5113223765557248
2020-06-04 00:13:57 +02:00
Feitian Technologies
f334f3eabe
Bug fixed ( #1859 )
...
* Bug fixed
1. It solves the problem that can be signed without input PIN, and new code will check the state that the PIN value
2. The algorithm fails to verify sha256, cause signature failure
3. The format of distinguishing ECC and RSA key pair is added - after the key pair is generated successfully, ECC and RSA need to be distinguished when reading the public key. The return format of ECC is different from the RSA
4. Fix ECC information display bug - The problem is using pkcs15-tool -D to print ECC key pair information no display correctly
5. Modify the module attribute of generating ECC key pair, and add 0x04 flag according to pkcs11 standard
2020-06-03 14:54:39 +02:00
Jakub Jelen
16456922e2
pkcs11: Return CKR_TOKEN_NOT_RECOGNIZED for not recognized cards
...
Fixes #2030
2020-05-30 16:00:04 +02:00
Jakub Jelen
e8a2644435
Remove duplicate condition
...
Thanks coverity
2020-05-29 09:57:39 +02:00
Jakub Jelen
38474739b3
card-cardos: Fix NULL dereference
...
Thanks coverity
2020-05-29 09:57:39 +02:00
Frank Morgner
0a17188710
fixed out of bounds read
...
fixes https://oss-fuzz.com/testcase-detail/5769032858075136
2020-05-24 23:47:29 +02:00
Piotr Majkrzak
d4a9405bf4
Initial support for Polish eID card (e-dowód, eDO) ( #2023 )
2020-05-19 14:05:13 +02:00
Frank Morgner
ed55fcd299
fixed invalid read
...
fixes https://oss-fuzz.com/testcase-detail/5765246676631552
2020-05-18 17:25:32 +02:00
Frank Morgner
96a7eca99a
fixed memory leak
...
fixes https://oss-fuzz.com/testcase-detail/5633315576217600
2020-05-18 17:13:48 +02:00
Frank Morgner
4cb9788b99
fixed invalid read
...
fixes https://oss-fuzz.com/testcase-detail/5726023753924608
2020-05-18 16:45:24 +02:00
Frank Morgner
7e1679b2db
fixed memory leak
...
fixes https://oss-fuzz.com/testcase-detail/5675417580339200
2020-05-18 16:38:43 +02:00
Torin Carey
93bed892a8
tests: Fix card present check
...
Check SC_READER_CARD_PRESENT flag rather than == 1.
Having no card present on the first loop and then inserting a card will
return rc = CARD_PRESENT | CARD_CHANGED (= 3). SEGFAULT ensures when we mistake
the unset opt_reader as having a present card.
2020-05-18 16:30:15 +02:00
Jakub Jelen
27a819baa7
framework-pkcs15: Do not leak memory (CID 139147)
2020-05-13 21:54:16 +02:00
Jakub Jelen
19791f63d5
piv: Avoid cast ignoring errors (CID 357984)
...
Thanks coverity
2020-05-13 21:54:16 +02:00
Jakub Jelen
787c32d195
piv: Avoid cast to unsigned ints to properly check for errors (CID 357985)
...
Thanks coverity scan
2020-05-13 21:54:16 +02:00
Frank Morgner
d8734baf83
Merge pull request #1924 from frankmorgner/recursion
...
avoid calling sc_*_binary recursively
2020-05-13 00:27:42 +02:00
Doug Engert
4ebb29ce4d
card-piv.c error in using sc_asn1-put-tag
...
In piv_general_mutual_authenticate sc_asn1_put_tag is not used correctly.
On branch piv-sc_asn1_put_tag-error
Changes to be committed:
modified: card-piv.c
2020-05-13 00:26:18 +02:00
Frank Morgner
4e9cec1a64
fixed missing includes
2020-05-11 18:58:12 +02:00
Frank Morgner
a7d563b657
Merge branch 'master' into recursion
2020-05-11 18:45:36 +02:00
Frank Morgner
0dcb910289
fixed "libtool: compile: unable to infer tagged configuration"
2020-05-11 18:41:16 +02:00
Frank Morgner
178c4a9eaa
fixed checking for strlcat/strlcpy
...
newer clang uses a definition rather than a function
2020-05-11 18:41:16 +02:00
Frank Morgner
c1eda42099
oberthur: fixed current file state handling
...
fixes https://oss-fuzz.com/testcase-detail/5644083327664128
2020-05-10 01:14:00 +02:00
Frank Morgner
7add7e9ded
fixed memory leak
...
fixes https://oss-fuzz.com/testcase-detail/5738653415636992
2020-05-10 01:01:34 +02:00
Michael Weiser
a49a64ec79
unittests: Fix out-of-source build
...
Commit 4fd34e28ea
unintentionally replaced top_builddir with
top_srcdir when refactoring flags variables in Makefile.am. This causes
out-of-source builds to fail.
Restore top_builddir in LDADD.
Also, remove a superfluous -L flag also referencing top_srcdir from
AM_CFLAGS while at it.
Signed-off-by: Michael Weiser <michael.weiser@gmx.de>
Closes #2027 .
2020-05-10 00:01:27 +02:00