6e3e81a9f4
Remove unused stored_length field.
2020-08-19 10:01:58 +02:00
48d939b057
Removed length_offset since it is not used any more.
2020-08-19 10:01:58 +02:00
aca0d08e29
Removed the 'crts' field from 'sc_acl_entry' type since:
...
- its definition is specific to the IAS-ECC card type
- its presence can not be assumed since it is read from non-mandatory SE type of an SDO
- it is currently not used anywhere in the code
2020-08-19 10:01:58 +02:00
376cc2d910
iso7816: set record_length for any record-oriented EF
2020-08-19 09:58:12 +02:00
ad81126c07
Fix link to virt_cacard project
2020-08-05 09:11:35 +02:00
cdbcb5b7db
coolkey: Fix AddressSanitizer: stack-use-after-scope
...
Thanks oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23979
2020-08-04 13:11:55 +02:00
8963c35189
pkcs15-sc-hsm: use correct name for EF.CDF
2020-08-03 15:34:22 +02:00
07e98b5193
pkcs15-sc-hsm: fix commit c4d7bb1
...
Set the trigger for LOG_TEST_RET() to a negative value if obj.data == NULL.
2020-08-03 15:34:22 +02:00
978c912c70
fixed Heap-buffer-overflow READ
...
7cf8087351https://oss-fuzz.com/testcase-detail/5734055866531840
2020-07-30 02:40:02 +02:00
6903aebfdd
Heap-buffer-overflow WRITE
...
fixes https://oss-fuzz.com/testcase-detail/5088104168554496
2020-07-30 02:27:02 +02:00
9ffb9bae63
tcos: add missing encryption certificates
2020-07-30 02:00:15 +02:00
2b78374e37
Print error message for the case that a PUK object is not available for a PIN
...
during an unblock operation (this is a sign of a card with invalid PKCS #15
info). Without this error message the program just terminates silently, which
is confusing to the user.
2020-07-22 22:58:57 +02:00
6f1df6454a
Reject the case that the PIN and PUK padding flags are different, since this
...
case can not be handled by the card driver interface. Better to detect and
fail early instead of sending invalid data to the card.
2020-07-22 22:58:57 +02:00
555cb73615
Fix for using the correct info for PIN/PUK (before they were switched).
2020-07-22 22:58:57 +02:00
e80906d973
Add path selection to sc_pkcs15_get_pin_info to make it work correctly with
...
local PINs. This makes the code behave the same way as PIN verification,
change and unblock, before calling the PIN command handler in the card driver.
2020-07-22 22:58:57 +02:00
bad74e1ed6
Enabled code for using PUK reference for PIN unblock, when available.
2020-07-22 22:57:23 +02:00
998284dd1c
Removed unused define.
2020-07-22 22:57:23 +02:00
ba76bc0239
Improved syntactic readability without any change in functionality.
2020-07-22 22:57:23 +02:00
c903ddfce1
Fixed bounds checking and enabled the function again.
2020-07-22 22:57:23 +02:00
163b69e6a7
Change ADF selection to return FCP for Oberthur cards. No need to simulate
...
since it is supported.
2020-07-22 22:57:23 +02:00
3331a7f134
Fix MF selection APDU to use 0x0c in P2 (no data). The previous value of 0x00
...
is invalid according to IAS-ECC and resulted in 6A 86 on the Oberthur
cards that we tested with.
2020-07-22 22:57:23 +02:00
471468260e
Improved PIN unblock function:
...
- Uses PIN padding from merged policy
- Added PIN-pad support
- Use ISO 7816 layer to avoid code duplication
2020-07-22 22:57:23 +02:00
79e81eeef0
Improved PIN change function:
...
- Uses PIN padding from merged policy
- Improved PIN-pad logic and merged here from separate function
2020-07-22 22:57:23 +02:00
5ae488c1b9
Improved PIN verification function:
...
- Uses PIN padding from merged policy
- Moved PIN-pad logic into this function instead of keeping separate
2020-07-22 22:57:23 +02:00
d0b3e90431
Simlified low-level CHV verification function:
...
- Removed special PIN-pad case, moving logic into high-level function.
- Use ISO 7816 layer to avoid code duplication.
2020-07-22 22:57:23 +02:00
8c2d629f94
Functions used to control PIN padding and PIN pad use:
...
- Use PIN padding information when provided by upper layers
- Enable PIN padding at card level when min/max len set to same, nonzero value
- Allow PIN-pad use to be dynamically selected for each PIN
2020-07-22 22:57:23 +02:00
ca911e342c
Improved PIN info retrieval, now returning verification status, and attempts
...
left even when previously not available (due to card not providing it in the
SDO).
2020-07-22 22:57:23 +02:00
19063932f0
Simplified PIN policy retrieval to only read the data that is actually needed,
...
excluding the CRT info from the SE-SDO, which is not guaranteed to be
available in all card types.
Use an explicit PIN policy structure type instead of keeping the info in the
sc_pin_cmd_data, since this type of info is only used privately in the card
driver.
2020-07-22 22:57:23 +02:00
741ee73ec9
Add generic function for PIN status retrieval, for subsequent use (among
...
others intended to replace iasecc_pin_is_verified).
Base it on functionality in the ISO 7816 layer to avoid code duplication.
2020-07-22 22:57:23 +02:00
7ed876c816
Added ATR mask for Idemia (Oberthur) IAS-ECC card to recognize Cosmo V8 cards.
2020-07-22 22:57:23 +02:00
eb3e00a385
Corrected highly misleading, confusing and ambiguous use of PIN length_offset
...
field. Now only the PIN offset fields are used. Also added error checking for
invalid values.
2020-07-22 22:56:09 +02:00
80853bda31
Only enable static frame size for PIN padding when padding length is below
...
maximum limits. Otherwise resort to adaptive support.
2020-07-22 22:56:09 +02:00
afffeccc29
Fixed problems with PIN min/max length handling:
...
- The wrong PIN was selected from the sc_pin_cmd_data structure.
- When the PIN max value was zero from the caller (meaning unknown max), the
reader max value was not used.
2020-07-22 22:56:09 +02:00
1dc359cb61
Fix for issue #1999 :
...
- Reset context to undefined handle value on error since call may alter
output parameter.
- Continue to assume -1 as undefined handle value in all PCSC
implementations, to keep this fix as small and surgical as possible.
2020-07-22 22:55:30 +02:00
b16a5cbee0
pkcs15: Free app info when allocating new and in cleanup
...
Thanks oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23746
2020-07-07 16:21:21 +02:00
c82aa92687
pkcs15: Clean memory on alocation failure
2020-07-07 16:21:21 +02:00
2d6de2510c
pkcs15: Drop bogus checks
2020-07-07 16:21:21 +02:00
4c473fba29
authentic: Clean private data on error
...
Thanks oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23786
2020-07-07 16:21:21 +02:00
05dcde508b
authentic: Use memmove as the memory can overlap (if path is > 2B)
...
Thanks oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23787
2020-07-07 16:21:21 +02:00
5098cfdb40
authentic: Do not leak memory on fail path
...
Thanks oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23788
2020-07-07 16:21:21 +02:00
7cf8087351
asepcos: Avoid heap-buffer-overflow
...
Thanks oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23529
2020-07-07 16:21:21 +02:00
c4d7bb1a7b
Do not crash on if private certificate is ignored ( #2057 )
2020-07-07 16:21:21 +02:00
43379b3b22
coolkey: Rewrite coolkey_rsa_op() for better readability
2020-07-07 16:21:21 +02:00
0cda376dba
pkcs15-pubkey: Make sc_pkcs15_pubkey_from_spki_fields more robust against errors
...
Original patch from Douglas E Engert <deengert@gmail.com>
2020-07-07 16:21:21 +02:00
e759b17b66
pkcs15-pubkey: Avoid memory leaks when spki parsing fails
...
Thanks oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22189
2020-07-07 16:21:21 +02:00
56f4c6c34a
piv: Free pubkey on error
...
Thanks oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22297
2020-07-07 16:21:21 +02:00
3696331d5c
Remove more needless checks for NULL before free
2020-07-07 16:21:21 +02:00
fea08d749d
coolkey: Avoid memory leak
...
Thanks oss-fuzz
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23251
2020-07-07 16:21:21 +02:00
054cb08c90
Add CII Best practices badge
...
this splits also badges to separate lines for simpler diffs. They are still rendered on single line
2020-07-07 12:37:58 +02:00
0defebfe05
doc: Recommend pin caching in combination with pin_cache_ignore_user_consent configuration option
2020-07-03 17:55:24 +02:00
Zoltan Kelemen
Peter Marschall
Jakub Jelen
Frank Morgner
Julian Strobl