Commit Graph

6289 Commits

Author SHA1 Message Date
Philip Wendland 328176d28b ECDSA helper functions: strip zeroes when converting from R,S to sequence
For ECDSA signatures, there are multiple ways to format the signature:
- R|S (R and S filled with zeroes at the most significant bytes)
- ASN1 sequence of R,S integers (e.g. used by OpenSSL).

It is rare that the filling with zeroes is needed.
But if it is, in the second case, the filling zeroes should not be there
or the verification of the signature by OpenSSL will fail.
2015-09-20 22:34:39 +02:00
Frank Morgner bc9e42ddd7 Merge pull request #556 from philipWendland/dead-code
IsoApplet: fix dead code + pincache
2015-09-18 17:54:12 +02:00
Philip Wendland 09fb1e71a9 IsoApplet: add PIN to pincache upon creation 2015-09-18 17:02:45 +02:00
Philip Wendland 6bffeb7a36 IsoApplet: fix dead code 2015-09-18 17:02:45 +02:00
Frank Morgner ba02d69f2b Merge pull request #555 from dengert/piv-readability
Fix indentation for readability
2015-09-18 10:13:23 +02:00
Doug Engert 24a3999386 Fix indentation for readability 2015-09-17 19:03:44 -05:00
Frank Morgner c399bc94ec piv-tool: fixed resource leak 2015-09-17 22:32:07 +02:00
Frank Morgner 2dca6ced06 pkcs15-oberthur: fixed resource leak 2015-09-17 22:32:07 +02:00
Frank Morgner 4e280b4741 pkcs15-lib: fixed resource leak 2015-09-17 22:32:07 +02:00
Frank Morgner 5854aff155 pkcs15-epass2003: fixed resource leak 2015-09-17 22:32:06 +02:00
Frank Morgner 4fd359406e iasecc-sdo: fixed resource leak 2015-09-17 22:32:06 +02:00
Frank Morgner 1308fd0618 cwa14890: fixed resource leak 2015-09-17 22:32:06 +02:00
Frank Morgner 7fe4819a02 card-tcos: fixed resource leak 2015-09-17 22:32:06 +02:00
Frank Morgner 1e2a42dae5 Fixes warning about unused variables 2015-09-17 22:24:33 +02:00
Frank Morgner fe31aceacb Fixes signature of iasecc_read_public_key 2015-09-17 22:24:33 +02:00
Frank Morgner be073396be Fixes warnings about unused variables/functions 2015-09-17 22:24:33 +02:00
Frank Morgner 0fe282414f Fixed warning about unused function 2015-09-17 22:24:33 +02:00
Frank Morgner 5902587889 Removed dead code 2015-09-17 22:24:33 +02:00
Frank Morgner c22ffd95bf Fixed warning about unused variable 2015-09-17 22:24:33 +02:00
Frank Morgner 6c01750ba8 Removes dead code 2015-09-17 22:24:33 +02:00
Frank Morgner e4bce1ca61 Fixes dependency on uninitialized data 2015-09-17 22:24:33 +02:00
Frank Morgner 07038225a7 Fixes out of bounds read 2015-09-17 22:24:33 +02:00
Frank Morgner 69320f9d54 Checks for out of bounds write 2015-09-17 22:24:33 +02:00
Frank Morgner f08985086a Fixes potential buffer overrun 2015-09-17 22:24:33 +02:00
Frank Morgner 69de207c21 Fixes bad type cast 2015-09-17 22:24:33 +02:00
Frank Morgner 59254d9d88 Checks on errors for ftell and fseek 2015-09-17 22:24:33 +02:00
Frank Morgner b5de72fe13 fix potention NULL deref 2015-09-17 22:24:33 +02:00
Frank Morgner 63a9ad79b6 Assumes that p15card->card are set
The check for NULL was bogus anyway
2015-09-17 22:24:33 +02:00
Frank Morgner 8a225eb42b Avoids potential NULL pointer deref 2015-09-17 22:24:33 +02:00
Frank Morgner 30d4f52718 Checks untrusted input 2015-09-17 22:24:33 +02:00
Frank Morgner ba3890f8e0 Checks result of calloc 2015-09-17 22:24:33 +02:00
Frank Morgner de58f51012 msc: check the length of input 2015-09-17 22:24:33 +02:00
Frank Morgner 547494f012 Merge pull request #552 from frankmorgner/innosetup
Improve the state of travis ci
2015-09-17 13:23:56 +02:00
Frank Morgner bdb856ffa2 Merge pull request #553 from frankmorgner/488
added missing files to WiX installer
2015-09-17 13:23:14 +02:00
Frank Morgner d20290d2b3 openpgp: match application, not ATR
fixes #391
closes #507
2015-09-16 09:48:23 +02:00
Robert Ou b28c48afe0 Fix OpenPGP driver to work correctly with YubiKey NEO 2015-09-16 09:48:23 +02:00
Frank Morgner 8aba7b9598 added missing files to WiX installer
fixes https://github.com/OpenSC/OpenSC/issues/488
2015-09-16 04:18:12 +02:00
Frank Morgner 989c06b25d OSX: don't ship with libp11/engine_pkcs11 anymore
both spin off projects should ship with a separate installer. See
discussion here https://github.com/OpenSC/OpenSC/issues/488
2015-09-16 03:52:00 +02:00
Frank Morgner 8fe8974333 Uses container based travis and caching 2015-09-16 03:52:00 +02:00
Frank Morgner fcfb0cebee build cross compiled installer with innosetup 2015-09-15 15:04:33 +02:00
Frank Morgner a524b4a0e3 Removes obsolete windows installer files 2015-09-15 15:04:33 +02:00
Frank Morgner 69783f4e6c Unifies project wide vendor/product strings 2015-09-15 15:04:32 +02:00
Frank Morgner cc6d7677da Merge pull request #550 from frankmorgner/appveyor
adjust Make.rules.mak to work with AppVeyor
2015-09-14 18:35:54 +02:00
Frank Morgner bf654540c5 Merge pull request #545 from frankmorgner/duplicate
avoid registering pkcs11 mechanisms multiple times
2015-09-14 12:41:37 +02:00
Frank Morgner d794baf0c6 Add workaround for canceling pending build jobs
As suggested here
https://github.com/appveyor/ci/issues/38#issuecomment-70628826
2015-09-14 07:49:51 +02:00
Frank Morgner fb9dfc5b71 fixed warnings about possible data loss 2015-09-14 10:52:31 +02:00
Frank Morgner f261426303 travis: cross compile for 64 bit windows 2015-09-14 10:52:31 +02:00
Frank Morgner 428385d8b4 adjust Make.rules.mak to work with AppVeyor
- The AppVeyor configuration of VS2014/VS2015 does not currently work
  with this script
- We are using the pre-built zlib binaries. As consequence, we can build
  the 32 bit installer only. Also, we can't use static linking anymore
- The current pre-built binaries of OpenSSL from
  https://slproweb.com/products/Win32OpenSSL.html include security
  measures (https://blogs.microsoft.com/cybertrust/2012/01/26/enhancements-to-gs-in-visual-studio-11/)
  that are not compatible with our version of VS `(error LNK2001:
  unresolved external symbol ___report_rangecheckfailure)`. That's why
  we can't use static linking anymore

works with
- OpenSSL 1.0.2
- zlib 2.1.8
- WiX 3.10
2015-09-14 10:52:31 +02:00
Frank Morgner 89be9d6e18 Merge pull request #303 from hongquan/gnuk
Gnuk support
2015-09-13 22:45:37 +02:00
Nguyễn Hồng Quân 76b6b483c7 Merge branch 'master' into gnuk 2015-09-13 22:09:59 +08:00