giomba
/
opensc
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

- SECURITY: Fixed buffer overflow 

git-svn-id: https://www.opensc-project.org/svnp/opensc/trunk@263 c6295689-39f2-0310-b995-f0e70906c6a9
This commit is contained in:
okir 2002-03-06 12:32:42 +00:00
parent 88553f6bfc
commit f39f2244bb
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/libopensc/pkcs15.c
View File

@ -536,7 +536,12 @@ int sc_pkcs15_bind(struct sc_card *card,
err = sc_select_file(card, &tmppath, &p15card->file_odf);
if (err) /* FIXME: finish writing error reporting stuff */
goto error;
err = sc_read_binary(card, 0, buf, p15card->file_odf->size, 0);
/* XXX: fix buffer overflow. Silently truncate ODF if it
* is too large. --okir */
if ((len = p15card->file_odf->size) > sizeof(buf))
len = sizeof(buf);
err = sc_read_binary(card, 0, buf, len, 0);
if (err < 0)
goto error;
if (err < 2) {