From 9ff8bd1c61318d022af38e639fc7ff0d54baaef7 Mon Sep 17 00:00:00 2001 From: Doug Engert Date: Thu, 14 Nov 2013 09:38:49 -0600 Subject: [PATCH] EC parameters not copied correctly As reported in Github, the memcpy was not valid. pkcs15-pubkey.c-20131106-09007 --- src/libopensc/pkcs15-pubkey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libopensc/pkcs15-pubkey.c b/src/libopensc/pkcs15-pubkey.c index 1109c1e5..834a6262 100644 --- a/src/libopensc/pkcs15-pubkey.c +++ b/src/libopensc/pkcs15-pubkey.c @@ -1020,7 +1020,7 @@ sc_pkcs15_pubkey_from_spki(sc_context_t *ctx, sc_pkcs15_pubkey_t ** outpubkey, struct sc_ec_params * ecp = (struct sc_ec_params *)pubkey->alg_id->params; pubkey->u.ec.params.der.value = malloc(ecp->der_len); if (pubkey->u.ec.params.der.value) { - memcpy(&pubkey->u.ec.params.der.value, &ecp->der, ecp->der_len); + memcpy(pubkey->u.ec.params.der.value, ecp->der, ecp->der_len); pubkey->u.ec.params.der.len = ecp->der_len; sc_pkcs15_fix_ec_parameters(ctx,&pubkey->u.ec.params); }