giomba/opensc
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Correctly check for reading out of file bounds, thx to Sirio Capizi

Browse Source 
git-svn-id: https://www.opensc-project.org/svnp/opensc/trunk@2223 c6295689-39f2-0310-b995-f0e70906c6a9
This commit is contained in:
sth 2005-03-02 06:03:49 +00:00
parent 11526e3ccf
commit e336488431
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/libopensc/pkcs15-cache.c
View File

@ -67,7 +67,7 @@ int sc_pkcs15_read_cached_file(struct sc_pkcs15_card *p15card,
const struct sc_path *path,
u8 **buf, size_t *bufsize)
{
char fname[160];
char fname[PATH_MAX];
int r;
FILE *f;
size_t count, offset, got;
@ -86,8 +86,7 @@ int sc_pkcs15_read_cached_file(struct sc_pkcs15_card *p15card,
} else {
count = path->count;
offset = path->index;
if (offset >= (size_t)stbuf.st_size
|| offset + count >= (size_t)stbuf.st_size)
if (offset + count > (size_t)stbuf.st_size)
return SC_ERROR_FILE_NOT_FOUND; /* cache file bad? */
}
if (*buf == NULL) {