From b90a5572370f686b7ac6f474a0f113d18f6da650 Mon Sep 17 00:00:00 2001 From: Ludovic Rousseau Date: Thu, 23 Aug 2012 23:45:23 +0200 Subject: [PATCH] Fix SC_PKCS15_TYPE_PRKEY_EC case Coverity: Missing break in switch (MISSING_BREAK) "A break statement was missing. The case SC_PKCS15_TYPE_PRKEY_EC was then managed as a SC_PKCS15_TYPE_PRKEY_DSA" (Ludovic Rousseau) "the break here has no sense, because LOG_TEST_RET will always return SC_ERROR_NOT_SUPPORTED before" (Frank Morgner https://github.com/OpenSC/OpenSC/pull/85) 'break' is kept to satisfy coverity. --- src/libopensc/pkcs15-prkey.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libopensc/pkcs15-prkey.c b/src/libopensc/pkcs15-prkey.c index d08195f8..aa26bc3f 100644 --- a/src/libopensc/pkcs15-prkey.c +++ b/src/libopensc/pkcs15-prkey.c @@ -398,6 +398,7 @@ int sc_pkcs15_encode_prkdf_entry(sc_context_t *ctx, const struct sc_pkcs15_objec break; case SC_PKCS15_TYPE_PRKEY_EC: LOG_TEST_RET(ctx, SC_ERROR_NOT_SUPPORTED, "EC private key type not supported"); + break; case SC_PKCS15_TYPE_PRKEY_DSA: sc_format_asn1_entry(asn1_prkey + 2, &dsa_prkey_obj, NULL, 1); sc_format_asn1_entry(asn1_prk_dsa_attr + 0, asn1_dsakey_value_attr, NULL, 1);