From ad11c9937c6c9f830d8149ff673397259a5c5b54 Mon Sep 17 00:00:00 2001 From: Ludovic Rousseau Date: Wed, 2 Mar 2016 14:57:42 +0100 Subject: [PATCH] card-authentic.c: fix 1 compiler warning card-authentic.c:1452:57: error: address of 'data->pin2.data' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] if (!data->pin1.data && !data->pin1.len && &data->pin2.data && !... ~~ ~~~~~~~~~~~^~~~ --- src/libopensc/card-authentic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libopensc/card-authentic.c b/src/libopensc/card-authentic.c index e7e111aa..a4b32d68 100644 --- a/src/libopensc/card-authentic.c +++ b/src/libopensc/card-authentic.c @@ -1449,7 +1449,7 @@ authentic_pin_change(struct sc_card *card, struct sc_pin_cmd_data *data, int *tr memset(prv_data->pins_sha1[data->pin_reference], 0, sizeof(prv_data->pins_sha1[0])); - if (!data->pin1.data && !data->pin1.len && &data->pin2.data && !data->pin2.len) { + if (!data->pin1.data && !data->pin1.len && !data->pin2.data && !data->pin2.len) { if (!(card->reader->capabilities & SC_READER_CAP_PIN_PAD)) LOG_TEST_RET(ctx, SC_ERROR_NOT_SUPPORTED, "PIN pad not supported"); rv = authentic_pin_change_pinpad(card, data->pin_reference, tries_left);