giomba
/
opensc
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

pkcs15-tool: Update the logic to make it more clear for some dumb static analyzers

This commit is contained in:
Jakub Jelen 2021-06-18 09:35:24 +02:00 committed by Jakub Jelen
parent d34e84c78d
commit 9a5a008093
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/tools/pkcs15-tool.c
View File

@ -987,13 +987,13 @@ static int read_ssh_key(void)
}
if (r == SC_ERROR_OBJECT_NOT_FOUND) {
if (outf != stdout)
if (opt_outfile != NULL)
fclose(outf);
fprintf(stderr, "Public key with ID '%s' not found.\n", opt_pubkey);
return 2;
}
if (r < 0) {
if (outf != stdout)
if (opt_outfile != NULL)
fclose(outf);
fprintf(stderr, "Public key enumeration failed: %s\n", sc_strerror(r));
return 1;
@ -1242,7 +1242,7 @@ static int read_ssh_key(void)
print_ssh_key(outf, "ssh-dss", obj, buf, len);
}
if (outf != stdout)
if (opt_outfile != NULL)
fclose(outf);
if (cert)
sc_pkcs15_free_certificate(cert);
@ -1252,7 +1252,7 @@ static int read_ssh_key(void)
fail:
printf("can't convert key: buffer too small\n");
fail2:
if (outf && outf != stdout)
if (opt_outfile != NULL && outf != NULL)
fclose(outf);
if (cert)
sc_pkcs15_free_certificate(cert);