giomba
/
opensc
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

opensc-explorer: replace magic numbers by SC_MAX_PIN_SIZE 

Replace magic numbers, used as size of PIN-type buffers,
with the symbolic constant SC_MAX_PIN_SIZE, fixing
- readability / understandability
- too small sizes (e.g. for GnuPG cards)
This commit is contained in:
Peter Marschall 2020-02-22 17:50:12 +01:00 committed by Frank Morgner
parent 70716be815
commit 95cae64f83
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/tools/opensc-explorer.c
View File

@ -1178,7 +1178,7 @@ static int do_verify(int argc, char **argv)
{ SC_AC_NONE, NULL, }
};
int r, tries_left = -1;
u8 buf[64];
u8 buf[SC_MAX_PIN_SIZE];
size_t buflen = sizeof(buf), i;
struct sc_pin_cmd_data data;
int prefix_len = 0;
@ -1263,8 +1263,8 @@ static int do_verify(int argc, char **argv)
static int do_change(int argc, char **argv)
{
int ref, r, tries_left = -1;
u8 oldpin[64];
u8 newpin[64];
u8 oldpin[SC_MAX_PIN_SIZE];
u8 newpin[SC_MAX_PIN_SIZE];
size_t oldpinlen = 0;
size_t newpinlen = 0;
struct sc_pin_cmd_data data;
@ -1328,8 +1328,8 @@ static int do_change(int argc, char **argv)
static int do_unblock(int argc, char **argv)
{
int ref, r;
u8 puk[64];
u8 newpin[64];
u8 puk[SC_MAX_PIN_SIZE];
u8 newpin[SC_MAX_PIN_SIZE];
size_t puklen = 0;
size_t newpinlen = 0;
struct sc_pin_cmd_data data;