giomba
/
opensc
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

iasecc: special case for 'Gemalto GemPC Pinpad' 

issue 424
VTA: this pinpad, the only available, do not accept different values
for min and max PIN lengths in P10 block.
This commit is contained in:
Viktor Tarasov 2015-04-04 21:05:19 +02:00
parent c0fac2a4f6
commit 95ad11a253
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/libopensc/card-iasecc.c
View File

@ -1801,12 +1801,14 @@ iasecc_chv_verify_pinpad(struct sc_card *card, struct sc_pin_cmd_data *pin_cmd,
LOG_FUNC_RETURN(ctx, SC_ERROR_READER);
}
if (pin_cmd->pin1.min_length != pin_cmd->pin1.max_length) {
sc_log(ctx, "Different values for PIN min and max lengths is not actually compatible with PinPAD.");
LOG_TEST_RET(ctx, SC_ERROR_NOT_SUPPORTED,
"Different values for PIN min and max lengths is not actually compatible with PinPAD.");
sc_log(ctx, "reader %s", card->reader->name);
if (strstr(card->reader->name, "Gemalto GemPC Pinpad") == card->reader->name) {
sc_log(ctx, "reader %s", card->reader->name);
if (pin_cmd->pin1.min_length != pin_cmd->pin1.max_length) {
sc_log(ctx, "Bogus Gemalto GemPC Pinpad do not accept different values for min and max PIN lengths.");
LOG_FUNC_RETURN(ctx, SC_ERROR_NOT_SUPPORTED);
}
}
pin_cmd->pin1.len = pin_cmd->pin1.min_length;
memset(buffer, 0xFF, sizeof(buffer));
@ -2037,8 +2039,10 @@ iasecc_chv_change_pinpad(struct sc_card *card, unsigned reference, int *tries_le
rv = iasecc_pin_get_policy(card, &pin_cmd);
LOG_TEST_RET(ctx, rv, "Get 'PIN policy' error");
if (pin_cmd.pin1.min_length != pin_cmd.pin1.max_length)
LOG_TEST_RET(ctx, SC_ERROR_NOT_SUPPORTED, "Different values for PIN min and max lengths is not allowed with PinPAD.");
if (strstr(card->reader->name, "Gemalto GemPC Pinpad") == card->reader->name)
if (pin_cmd.pin1.min_length != pin_cmd.pin1.max_length)
LOG_TEST_RET(ctx, SC_ERROR_NOT_SUPPORTED,
"Bogus Gemalto GemPC Pinpad do not accept different values for min and max PIN lengths.");
if (pin_cmd.pin1.min_length < 4)
pin_cmd.pin1.min_length = 4;
@ -2083,8 +2087,10 @@ iasecc_chv_set_pinpad(struct sc_card *card, unsigned char reference)
rv = iasecc_pin_get_policy(card, &pin_cmd);
LOG_TEST_RET(ctx, rv, "Get 'PIN policy' error");
if (pin_cmd.pin1.min_length != pin_cmd.pin1.max_length)
LOG_TEST_RET(ctx, SC_ERROR_NOT_SUPPORTED, "Different values for PIN min and max lengths is not allowed with PinPAD.");
if (strstr(card->reader->name, "Gemalto GemPC Pinpad") == card->reader->name)
if (pin_cmd.pin1.min_length != pin_cmd.pin1.max_length)
LOG_TEST_RET(ctx, SC_ERROR_NOT_SUPPORTED,
"Bogus Gemalto GemPC Pinpad do not accept different values for min and max PIN lengths.");
if (pin_cmd.pin1.min_length < 4)
pin_cmd.pin1.min_length = 4;