From 889d598bcd242447b4bd7db22106b008b605a849 Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Thu, 17 Oct 2019 15:04:58 +0200 Subject: [PATCH] asn1: Initialize values to avoid comparison with garbage Reported by clang analyzer: src/libopensc/asn1.c:2115:14: warning: The right operand of '<' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult] if (halflen < r_len || halflen < s_len) { --- src/libopensc/asn1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libopensc/asn1.c b/src/libopensc/asn1.c index f6698b2e..df074e40 100644 --- a/src/libopensc/asn1.c +++ b/src/libopensc/asn1.c @@ -2047,7 +2047,7 @@ sc_asn1_sig_value_sequence_to_rs(struct sc_context *ctx, const unsigned char *in struct sc_asn1_entry asn1_sig_value[C_ASN1_SIG_VALUE_SIZE]; struct sc_asn1_entry asn1_sig_value_coefficients[C_ASN1_SIG_VALUE_COEFFICIENTS_SIZE]; unsigned char *r = NULL, *s = NULL; - size_t r_len, s_len, halflen = buflen/2; + size_t r_len = 0, s_len = 0, halflen = buflen/2; int rv; LOG_FUNC_CALLED(ctx);