From 723129bc123699ef72332ed106628236b96bd20d Mon Sep 17 00:00:00 2001 From: Lewis Porter Date: Tue, 7 Jan 2020 20:44:09 +0200 Subject: [PATCH] Check if card name is null in acos atrust driver MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit opensc-tool segfaults when trying to read a card that doen’t populate the name field. This commit adds a null check before calling strcmp(). --- src/libopensc/card-atrust-acos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libopensc/card-atrust-acos.c b/src/libopensc/card-atrust-acos.c index 83da3923..86bbf7ab 100644 --- a/src/libopensc/card-atrust-acos.c +++ b/src/libopensc/card-atrust-acos.c @@ -123,7 +123,7 @@ static int atrust_acos_init(struct sc_card *card) | SC_ALGORITHM_RSA_HASH_RIPEMD160 | SC_ALGORITHM_RSA_HASH_MD5_SHA1; - if (!strcmp(card->name, ACOS_EMV_A05)) + if (card->name != NULL && !strcmp(card->name, ACOS_EMV_A05)) flags |= SC_ALGORITHM_RSA_HASH_SHA256; _sc_card_add_rsa_alg(card, 1536, flags, 0x10001);