From 62403eec34d3dadb1a81c94f6b4803b7c1be55b3 Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Fri, 5 Jun 2020 10:38:18 +0200 Subject: [PATCH] tcos: Use memset instead of for cycle --- src/libopensc/card-tcos.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/libopensc/card-tcos.c b/src/libopensc/card-tcos.c index a84ec5ce..0e178fe4 100644 --- a/src/libopensc/card-tcos.c +++ b/src/libopensc/card-tcos.c @@ -535,7 +535,7 @@ static int tcos_restore_security_env(sc_card_t *card, int se_num) static int tcos_compute_signature(sc_card_t *card, const u8 * data, size_t datalen, u8 * out, size_t outlen) { - size_t i, dlen = datalen; + size_t dlen = datalen; sc_apdu_t apdu; u8 rbuf[SC_MAX_APDU_BUFFER_SIZE]; u8 sbuf[SC_MAX_APDU_BUFFER_SIZE]; @@ -568,9 +568,7 @@ static int tcos_compute_signature(sc_card_t *card, const u8 * data, size_t datal } sc_format_apdu(card, &apdu, keylen > 255 ? SC_APDU_CASE_4_EXT : SC_APDU_CASE_4_SHORT, 0x2A, 0x80, 0x86); - for (i = 0; i < sizeof(sbuf); ++i) { - sbuf[i] = 0xff; - } + memset(sbuf, 0xff, sizeof(sbuf)); sbuf[0] = 0x02; sbuf[1] = 0x00; sbuf[2] = 0x01; @@ -594,9 +592,7 @@ static int tcos_compute_signature(sc_card_t *card, const u8 * data, size_t datal } sc_format_apdu(card, &apdu, SC_APDU_CASE_4_SHORT, 0x2A, 0x80, 0x86); - for (i = 0; i < sizeof(sbuf); ++i) { - sbuf[i] = 0xff; - } + memset(sbuf, 0xff, sizeof(sbuf)); sbuf[0] = 0x02; sbuf[1] = 0x00; sbuf[2] = 0x01;