giomba
/
opensc
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

pkcs15-isoApplet: Avoid uninitialized reads 

Thanks coverity

CID 365817
This commit is contained in:
Jakub Jelen 2021-02-11 12:23:10 +01:00 committed by Frank Morgner
parent 46cfe89b3c
commit 5f7c91e54f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pkcs15init/pkcs15-isoApplet.c
View File

@ -454,6 +454,8 @@ isoApplet_generate_key_ec(const sc_pkcs15_prkey_info_t *key_info, sc_card_t *car
LOG_FUNC_CALLED(card->ctx);
memset(&args, 0, sizeof(args));
/* Check key size: */
if(key_info->field_length == 0)
{
@ -472,8 +474,6 @@ isoApplet_generate_key_ec(const sc_pkcs15_prkey_info_t *key_info, sc_card_t *car
/* Generate the key.
* Note: The field size is not explicitly passed to the card.
* As we only support FP curves, the field length can be calculated from any parameter. */
memset(&args, 0, sizeof(args));
args.pubkey.ec.params.prime.value = curve->prime.value;
args.pubkey.ec.params.prime.len = curve->prime.len;
args.pubkey.ec.params.coefficientA.value = curve->coefficientA.value;