From 54dd9f4878cf11c25bc742b0503cf6aaeeddb536 Mon Sep 17 00:00:00 2001 From: Peter Marschall Date: Sat, 22 Dec 2018 20:28:09 +0100 Subject: [PATCH] OpenPGP: revert 4d8b2c12ed1dcada1d02fc88b3886e47ef652b04 It broke OpenPGP on Yubikey NEOs and maybe other older versions too. Reverting it restores functionality for those Yubikeys. --- src/libopensc/card-openpgp.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/libopensc/card-openpgp.c b/src/libopensc/card-openpgp.c index 5cc54a2e..3470f707 100644 --- a/src/libopensc/card-openpgp.c +++ b/src/libopensc/card-openpgp.c @@ -710,17 +710,6 @@ pgp_get_card_features(sc_card_t *card) pgp_parse_hist_bytes(card, hist_bytes+2, hist_bytes_len-2); } break; - default: - /* Something else is non-standard according to - * ISO7816-4 section 8 - Historical bytes, - * but used by Yubico, which should have all - * the needed capabilities*/ - if (hist_bytes_len >= 7 && - memcmp(hist_bytes, "Yubikey", 7) == 0) { - card->caps |= SC_CARD_CAP_APDU_EXT; - priv->ext_caps |= EXT_CAP_APDU_EXT - | EXT_CAP_CHAINING; - } } }