From 35cb70b5d664c4be417dee2cbe6b652185e6da2d Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Mon, 17 Dec 2018 18:44:23 -0800 Subject: [PATCH] Remove redundant logging Same information is printed a few line below in same function, the only difference is that there it takes care of case when label is NULL pointer unlike this line secondly, every function call to cosm_write_tokeninfo() in this file passes label=NULL, and then it tries to print a null pointer Fixes errors like src/libopensc/log.h:48:47: error: '%s' directive argument is null [-Werror=format-overflow=] Signed-off-by: Khem Raj --- src/pkcs15init/pkcs15-oberthur.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/pkcs15init/pkcs15-oberthur.c b/src/pkcs15init/pkcs15-oberthur.c index 322a74a4..98a61d5a 100644 --- a/src/pkcs15init/pkcs15-oberthur.c +++ b/src/pkcs15init/pkcs15-oberthur.c @@ -70,7 +70,6 @@ cosm_write_tokeninfo (struct sc_pkcs15_card *p15card, struct sc_profile *profile ctx = p15card->card->ctx; SC_FUNC_CALLED(ctx, SC_LOG_DEBUG_VERBOSE); - sc_log(ctx, "cosm_write_tokeninfo() label '%s'; flags 0x%X", label, flags); if (sc_profile_get_file(profile, COSM_TITLE"-token-info", &file)) { rv = SC_ERROR_INCONSISTENT_PROFILE; SC_TEST_GOTO_ERR(ctx, SC_LOG_DEBUG_VERBOSE, rv, "Cannot find "COSM_TITLE"-token-info");