From 2ea5ed8ddd7bad2b2620e73e9af93b27382e3f4b Mon Sep 17 00:00:00 2001 From: Ludovic Rousseau Date: Wed, 5 May 2021 13:53:06 +0200 Subject: [PATCH] Fix 'make check' when make --jobs= is used The error was: PASS: test-duplicate-symbols.sh PASS: test-pkcs11-tool-allowed-mechanisms.sh XFAIL: test-pkcs11-tool-test.sh XFAIL: test-pkcs11-tool-test-threads.sh PASS: test-manpage.sh FAIL: test-pkcs11-tool-sign-verify.sh ============================================================================ Testsuite summary for OpenSC 0.22.0-rc1 ============================================================================ ============================================================================ See tests/test-suite.log Please report to https://github.com/OpenSC/OpenSC/issues ============================================================================ This is because more than 1 test is executed at the same time. So card_cleanup() is called at the end of one test while another test is still running. The problem is easy to replicate using "make --jobs=2". --- tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 1d95b30c..aa43668d 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -15,6 +15,7 @@ dist_noinst_SCRIPTS = common.sh \ test-pkcs11-tool-sign-verify.sh \ test-pkcs11-tool-allowed-mechanisms.sh +.NOTPARALLEL: TESTS = \ test-manpage.sh \ test-duplicate-symbols.sh \