giomba
/
opensc
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

cwa-14890: little issue in cwa_external_auth 

# closes #903
This commit is contained in:
ricky 2016-11-13 11:07:57 +01:00 committed by Viktor Tarasov
parent e6dca49169
commit 282632f7e6
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/libopensc/cwa14890.c
View File

@ -733,7 +733,7 @@ static int cwa_external_auth(sc_card_t * card, cwa_sm_status_t * sm)
LOG_FUNC_CALLED(ctx);
/* compose apdu for External Authenticate cmd */
dnie_format_apdu(card, &apdu, SC_APDU_CASE_3_SHORT, 0x82, 0x00, 0x00, 0, sizeof(sm->sig),
dnie_format_apdu(card, &apdu, SC_APDU_CASE_4_SHORT, 0x82, 0x00, 0x00, 255, sizeof(sm->sig),
resp, MAX_RESP_BUFFER_SIZE, sm->sig, sizeof(sm->sig));
/* send composed apdu and parse result */
@ -1583,7 +1583,7 @@ int cwa_encode_apdu(sc_card_t * card,
&k1, &k2, DES_ENCRYPT);
/* compose and add computed MAC TLV to result buffer */
tlv_len = (card->atr.value[15] >= DNIE_30_VERSION)? 8 : 4;
tlv_len = (card->atr.value[15] >= DNIE_30_VERSION)? 8 : 4;
sc_log(ctx, "Using TLV lenght: %d", tlv_len);
res = cwa_compose_tlv(card, 0x8E, tlv_len, macbuf, &apdubuf, &apdulen);
if (res != SC_SUCCESS) {
@ -1720,7 +1720,7 @@ int cwa_decode_response(sc_card_t * card,
res = SC_ERROR_INVALID_DATA;
goto response_decode_end;
}
tlv_len = (card->atr.value[15] >= DNIE_30_VERSION)? 8 : 4;
tlv_len = (card->atr.value[15] >= DNIE_30_VERSION)? 8 : 4;
if (m_tlv->len != tlv_len) {
msg = "Invalid MAC TAG Length";
res = SC_ERROR_INVALID_DATA;