From 0977b5496ad7f35f6575555714e2c352ce85285e Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Wed, 6 Nov 2019 13:52:49 +0100 Subject: [PATCH] pkcs15-pubkey: Avoid memory leaks Thanks oss-fuzz https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=18758 --- src/libopensc/pkcs15-pubkey.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libopensc/pkcs15-pubkey.c b/src/libopensc/pkcs15-pubkey.c index 34dfa279..2f6eaa29 100644 --- a/src/libopensc/pkcs15-pubkey.c +++ b/src/libopensc/pkcs15-pubkey.c @@ -311,6 +311,9 @@ int sc_pkcs15_decode_pukdf_entry(struct sc_pkcs15_card *p15card, memset(gostr3410_params, 0, sizeof(gostr3410_params)); r = sc_asn1_decode(ctx, asn1_pubkey, *buf, *buflen, buf, buflen); + if (r < 0) { + free(der->value); + } if (r == SC_ERROR_ASN1_END_OF_CONTENTS) goto err; LOG_TEST_GOTO_ERR(ctx, r, "ASN.1 decoding failed");